Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor logic to determine comment type for "Toggle comment" command #340

Merged
merged 8 commits into from Mar 6, 2024

Conversation

felixhabib
Copy link
Contributor

@felixhabib felixhabib commented Mar 6, 2024

Fixes an issue where full line expression slots outside any JSX tags would be line commented rather than block commented.

Example of problem

Screen.Recording.2024-03-06.at.13.27.09.mov

Copy link

changeset-bot bot commented Mar 6, 2024

🦋 Changeset detected

Latest commit: bac6d25

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
playroom Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@felixhabib felixhabib changed the title Fix commenting Refactor logic to determine comment type Mar 6, 2024
@felixhabib felixhabib marked this pull request as ready for review March 6, 2024 02:29
@felixhabib felixhabib requested a review from a team as a code owner March 6, 2024 02:29
@felixhabib felixhabib changed the title Refactor logic to determine comment type Refactor logic to determine comment type for "Toggle comment" command Mar 6, 2024
@felixhabib felixhabib merged commit 71f694a into master Mar 6, 2024
6 checks passed
@felixhabib felixhabib deleted the fix-commenting branch March 6, 2024 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants