Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "Find", "Find and replace", and "Jump to line" keyboard shortcuts #343

Merged
merged 37 commits into from Mar 7, 2024
Merged

Add "Find", "Find and replace", and "Jump to line" keyboard shortcuts #343

merged 37 commits into from Mar 7, 2024

Conversation

felixhabib
Copy link
Contributor

@felixhabib felixhabib commented Mar 6, 2024 •
edited

Adding the following keyboard shortcuts:

  • Cmd + F / Ctrl + F - Find
  • Cmd + Option + F / Ctrl + Alt + F - Find and replace
  • Cmd + G / Ctrl + G - Jump to line

Copying the VSCode shortcut for 'Find and replace' but happy to discuss if something else is preferable

michaeltaranto and others added 30 commits February 26, 2024 11:41
@michaeltaranto
Add find and replace functionality
ee28b06
@michaeltaranto
Shift code below search bar
a568b6a
@michaeltaranto
Prevent browser shortcuts while search is focused
a75448d
@michaeltaranto
Add tests
07a4caa
@michaeltaranto
Assert focus before running commands
74b4f5a
@michaeltaranto
Merge branch 'master' into add-search-replace
7f5d7c3
@felixhabib
Change 'Replace (⌘R)' to 'Find and replace (⌘⌥F)'
65ec147 
Update commands in tests
@michaeltaranto
Refactor tests
2b79671
@michaeltaranto
Add waits
b7b0c39
@michaeltaranto
Type escape differently
90719ad
@michaeltaranto
Whitespace 😘
019a6df
@michaeltaranto
Increase waits
aae4268
@felixhabib
Replace get search field with get dialog and find search field
893e393
@felixhabib
Try forcing and retrying
465b28e 
This reverts commit 893e393.
@felixhabib
Try without force
09d82a5
@felixhabib
Add back force and refactor
ef2e11e 
This reverts commit 09d82a5.
@felixhabib
Always force for typeInSearchField
ccd143b
@felixhabib
Fix typo
f33cd0f
@felixhabib
Fix changeset
b87ff0a
@felixhabib
Try without waits
4517ced
@felixhabib
Add wait for jumpToLine only
abc2e79
@felixhabib
Add back all waits
b49ca5c
@felixhabib
Merge branch 'master' into add-search-replace
db25e34
@felixhabib
Remove retries
e8aceb9
@felixhabib
Rollback typecode change
86a597b
@felixhabib
Remove assertCodePaneHasFocus
84c49ab 
Update tests to handle assert in simpler ways
@felixhabib
Add comment to explain waits
f6ef488
@felixhabib
Try without force
33df989
@felixhabib
Revert "Try without force"
54100c1 
This reverts commit 33df989.
@felixhabib
Fix incorrectly written test
3343d81
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Mar 6, 2024 •
edited

🦋 Changeset detected

Latest commit: e44a3d2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
playroom Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@felixhabib felixhabib changed the title Add search replace Add "Fine", "Find and replace", and "Jump to line" keyboard shortcuts Mar 6, 2024
@felixhabib felixhabib marked this pull request as ready for review March 6, 2024 06:00
@felixhabib felixhabib requested a review from a team as a code owner March 6, 2024 06:00
@felixhabib felixhabib changed the title Add "Fine", "Find and replace", and "Jump to line" keyboard shortcuts Add "Find", "Find and replace", and "Jump to line" keyboard shortcuts Mar 6, 2024
askoufis
askoufis reviewed Mar 7, 2024
View reviewed changes
.changeset/good-starfishes-share.md Outdated Show resolved Hide resolved
.changeset/good-starfishes-share.md Outdated Show resolved Hide resolved
felixhabib and others added 3 commits March 7, 2024 14:58
@felixhabib @askoufis
Update changeset
40a1243 
Co-authored-by: Adam Skoufis <askoufis@users.noreply.github.com>
@felixhabib
Update changeset for brevity and clarity
dd21a42
@felixhabib
Ditto
e44a3d2
@felixhabib felixhabib requested a review from askoufis March 7, 2024 04:00
@felixhabib felixhabib merged commit 94c75f8 into master Mar 7, 2024
6 checks passed
@felixhabib felixhabib deleted the add-search-replace branch March 7, 2024 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@askoufis askoufis askoufis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@felixhabib @askoufis @michaeltaranto