Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reliability issues in Cypress tests for search related keyboard shortcuts #345

Merged
merged 1 commit into from Mar 7, 2024

Conversation

felixhabib
Copy link
Contributor

@felixhabib felixhabib commented Mar 7, 2024

Currently, Cypress tests in CI are unreliable and will only pass a slim majority of the time. This change adds some more time for new search-related shortcut tests to ensure Playroom has settled after shortcuts are triggered. This branch has passed Cypress in CI over 10 times and is proving more reliable.

  • Increase wait times for "Find", "Find and replace" and "Jump to line" functions in Cypress tests
  • Remove force from typeInSearchField function

Copy link

changeset-bot bot commented Mar 7, 2024

⚠️ No Changeset found

Latest commit: 666b1e8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@felixhabib felixhabib changed the title Remove one force and increase wait times Increase wait times for "Find", "Find and replace" and "Jump to line" functions in Cypress tests Mar 7, 2024
@felixhabib felixhabib changed the title Increase wait times for "Find", "Find and replace" and "Jump to line" functions in Cypress tests Fix reliability issues in Cypress tests for "Find" related keyboard shortcuts Mar 7, 2024
@felixhabib felixhabib changed the title Fix reliability issues in Cypress tests for "Find" related keyboard shortcuts Fix reliability issues in Cypress tests for search related keyboard shortcuts Mar 7, 2024
@felixhabib felixhabib marked this pull request as ready for review March 7, 2024 22:28
@felixhabib felixhabib requested a review from a team as a code owner March 7, 2024 22:28
@felixhabib felixhabib merged commit d5c2985 into master Mar 7, 2024
6 checks passed
@felixhabib felixhabib deleted the fix-flaky-tests branch March 7, 2024 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants