Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix side panel exit animation #349

Closed
wants to merge 1 commit into from
Closed

Conversation

felixhabib
Copy link
Contributor

Improve the side panel exit animation by not the hiding of panel content before the animation has completely finished. As a result, the panel will always display the content of the most recently active tab, even during the closing animation.

Before (10% speed)

before.mov

After (10% speed)

after.mov

@felixhabib felixhabib requested a review from a team as a code owner May 8, 2024 00:10
Copy link

changeset-bot bot commented May 8, 2024

⚠️ No Changeset found

Latest commit: 716677d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@felixhabib felixhabib marked this pull request as draft May 8, 2024 00:10
@felixhabib felixhabib closed this May 8, 2024
@felixhabib felixhabib deleted the fix-close-panel-animation branch May 9, 2024 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant