Fix side panel exit animation #350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not working Getting there but flaky Handle switching between panels Refactor
Remove import
🦋 Changeset detectedLatest commit: ed29c47 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
askoufis
reviewed
May 10, 2024
Co-authored-by: Adam Skoufis <askoufis@users.noreply.github.com>
askoufis
reviewed
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve the side panel exit animation by not the hiding of panel content before the animation has completely finished. As a result, the panel will always display the content of the most recently active tab, even during the closing animation.
Using
react-transition-grouplibrary to unmount the side panel on exit.Before (10% speed)
before.mov
After (10% speed)
after.mov