Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import rynovate into the renovate-config-seek namespace #21

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

AaronMoat
Copy link

@AaronMoat AaronMoat commented Apr 8, 2024

  • Delete all our files
  • Copy all files from seek-oss/rynovate@598ee7d
  • In another commit, find and replace rynovate -> renovate-config-seek

This requires workshopping, but keen for feedback and direction.

As a short summary of conversations, rynovate has evolved to be the defacto standard across SEEK and it would be good to promote that to the renovate-config-seek namespace.

There is more work to do here before widespread usage, but getting this initial diff in will help conversations

@AaronMoat AaronMoat marked this pull request as ready for review April 8, 2024 00:23
default.json Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Do we intend to take over the default here? An alternative may be to reroute github>seek-oss/rynovate to a named preset like github>seek-oss/renovate-config-seek:recommended.
  2. Existing renovate-config-seek consumers go via npm package, so while we don't need to reserve default, there is an open question about where we migrate them to (default, third-party-major, a separate preset that retains prior renovate-config-seek behaviour?)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. No strong opinions personally
  2. There are very few consumers and they'll need to actively migrate away. That doesn't answer your question. I know Jahred was keen on having a preset that has similar functionality to the existing, which I'm open to doing in this PR or a follow up

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know Jahred was keen on having a preset that has similar functionality to the existing

I'm keen to interrogate this use case over an alternative like third-party-major. When is it acceptable for a system owner to ignore major revisions of their third-party dependencies from a tech health perspective?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hadn't really looked at third-party-major before but it seems like a fairly reasonable alternative to the old renovate-seek-config, to me (majors + seek package minor/patches)

@@ -1,85 +1,21 @@
{
"name": "renovate-config-seek",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume this means that we are moving from a versioned npm model (repos must explicitly upgrade to the new package version) to a GitHub default branch model (repos automatically receive merged changes). I like this change but is it contentious to anyone else?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

package.json Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@@ -0,0 +1 @@
* @seek-oss/indirect
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reminder to change this

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Open to changing this in the PR if we can come to an agreement

Copy link
Author

@AaronMoat AaronMoat Apr 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about:

Suggested change
* @seek-oss/indirect
* @seek-oss/sig-backend-tooling @seek-oss/sku-maintainers

(and adjusting the admin access as per ^)

@jahredhope @72636c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants