Async import node-emoji (#900)

seek-oss · Nov 20, 2023 · 2b930a0 · 2b930a0
1 parent aa48154
commit 2b930a0
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 4 deletions.
diff --git a/.changeset/stupid-news-chew.md b/.changeset/stupid-news-chew.md
@@ -0,0 +1,5 @@
+---
+'sku': patch
+---
+
+Asynchronously import `node-emoji` to fix ESM require issue
diff --git a/packages/sku/config/webpack/plugins/sku-webpack-plugin/validateOptions.js b/packages/sku/config/webpack/plugins/sku-webpack-plugin/validateOptions.js
@@ -2,11 +2,12 @@ const Validator = require('fastest-validator');
 const browserslist = require('browserslist');
 const { yellow, red, bold, underline, white } = require('chalk');
 const didYouMean = require('didyoumean2').default;
-const { emojify } = require('node-emoji');
 
 const validator = new Validator();
 
-const exitWithErrors = (errors) => {
+const exitWithErrors = async (errors) => {
+  const { emojify } = await import('node-emoji');
+
   console.log(bold(underline(red('SkuWebpackPlugin: Invalid options'))));
   errors.forEach((error) => {
     console.log(yellow(emojify(error)));

diff --git a/packages/sku/context/validateConfig.js b/packages/sku/context/validateConfig.js
@@ -1,15 +1,16 @@
 const browserslist = require('browserslist');
 const { yellow, red, bold, underline, white } = require('chalk');
 const didYouMean = require('didyoumean2').default;
-const { emojify } = require('node-emoji');
 
 const configSchema = require('./configSchema');
 const defaultSkuConfig = require('./defaultSkuConfig');
 const defaultClientEntry = require('./defaultClientEntry');
 
 const availableConfigKeys = Object.keys(defaultSkuConfig);
 
-const exitWithErrors = (errors) => {
+const exitWithErrors = async (errors) => {
+  const { emojify } = await import('node-emoji');
+
   console.log(bold(underline(red('Errors in sku config:'))));
   errors.forEach((error) => {
     console.log(yellow(emojify(error)));