Ensure all gitignored sku-generated files are also ignored by prettie…

…r and eslint (#957)
seek-oss · May 6, 2024 · a13c06c · a13c06c
1 parent 2fa94c8
commit a13c06c
Show file tree

Hide file tree

Showing 38 changed files with 229 additions and 46 deletions.
diff --git a/.changeset/heavy-doors-doubt.md b/.changeset/heavy-doors-doubt.md
@@ -0,0 +1,23 @@
+---
+'sku': patch
+---
+
+Ensure all sku-generated gitignored files are present in `.prettierignore` and `.eslintignore` too
+
+Consumers should notice a few new files being added to the sku-managed sections within `.prettierignore` and `.eslintignore` the next time a `sku` command is run:
+
+```diff
+# managed by sku
+*.less.d.ts
++.eslintcache
++.eslintrc
++.prettierrc
+.storybook/main.js
+coverage/
+dist-storybook/
+dist/
+report/
+# end managed by sku
+```
+
+These changes should be committed to your repo.
diff --git a/fixtures/assertion-removal/.eslintignore b/fixtures/assertion-removal/.eslintignore
@@ -1,5 +1,8 @@
 # managed by sku
 *.less.d.ts
+.eslintcache
+.eslintrc
+.prettierrc
 .storybook/main.js
 coverage/
 dist-storybook/

diff --git a/fixtures/assertion-removal/.prettierignore b/fixtures/assertion-removal/.prettierignore
@@ -1,5 +1,8 @@
 # managed by sku
 *.less.d.ts
+.eslintcache
+.eslintrc
+.prettierrc
 .storybook/main.js
 coverage/
 dist-storybook/

diff --git a/fixtures/braid-design-system/.eslintignore b/fixtures/braid-design-system/.eslintignore
@@ -1,5 +1,8 @@
 # managed by sku
 *.less.d.ts
+.eslintcache
+.eslintrc
+.prettierrc
 .storybook/main.js
 coverage/
 dist-storybook/

diff --git a/fixtures/braid-design-system/.prettierignore b/fixtures/braid-design-system/.prettierignore
@@ -1,5 +1,8 @@
 # managed by sku
 *.less.d.ts
+.eslintcache
+.eslintrc
+.prettierrc
 .storybook/main.js
 coverage/
 dist-storybook/

diff --git a/fixtures/custom-src-paths/.eslintignore b/fixtures/custom-src-paths/.eslintignore
@@ -1,5 +1,8 @@
 # managed by sku
 *.less.d.ts
+.eslintcache
+.eslintrc
+.prettierrc
 .storybook/main.js
 coverage/
 dist-storybook/

diff --git a/fixtures/custom-src-paths/.prettierignore b/fixtures/custom-src-paths/.prettierignore
@@ -1,5 +1,8 @@
 # managed by sku
 *.less.d.ts
+.eslintcache
+.eslintrc
+.prettierrc
 .storybook/main.js
 coverage/
 dist-storybook/

diff --git a/fixtures/library-build/.eslintignore b/fixtures/library-build/.eslintignore
@@ -1,5 +1,8 @@
 # managed by sku
 *.less.d.ts
+.eslintcache
+.eslintrc
+.prettierrc
 .storybook/main.js
 coverage/
 dist-storybook/

diff --git a/fixtures/library-build/.prettierignore b/fixtures/library-build/.prettierignore
@@ -1,5 +1,8 @@
 # managed by sku
 *.less.d.ts
+.eslintcache
+.eslintrc
+.prettierrc
 .storybook/main.js
 coverage/
 dist-storybook/

diff --git a/fixtures/library-file/.eslintignore b/fixtures/library-file/.eslintignore
@@ -1,5 +1,8 @@
 # managed by sku
 *.less.d.ts
+.eslintcache
+.eslintrc
+.prettierrc
 .storybook/main.js
 coverage/
 dist-storybook/

diff --git a/fixtures/library-file/.prettierignore b/fixtures/library-file/.prettierignore
@@ -1,5 +1,8 @@
 # managed by sku
 *.less.d.ts
+.eslintcache
+.eslintrc
+.prettierrc
 .storybook/main.js
 coverage/
 dist-storybook/

diff --git a/fixtures/lint-format/.eslintignore b/fixtures/lint-format/.eslintignore
@@ -1,5 +1,8 @@
 # managed by sku
 *.less.d.ts
+.eslintcache
+.eslintrc
+.prettierrc
 .storybook/main.js
 coverage/
 dist-storybook/

diff --git a/fixtures/lint-format/.prettierignore b/fixtures/lint-format/.prettierignore
@@ -1,5 +1,8 @@
 # managed by sku
 *.less.d.ts
+.eslintcache
+.eslintrc
+.prettierrc
 .storybook/main.js
 coverage/
 dist-storybook/

diff --git a/fixtures/multiple-routes/.eslintignore b/fixtures/multiple-routes/.eslintignore
@@ -1,5 +1,8 @@
 # managed by sku
 *.less.d.ts
+.eslintcache
+.eslintrc
+.prettierrc
 .storybook/main.js
 coverage/
 dist-storybook/

diff --git a/fixtures/multiple-routes/.prettierignore b/fixtures/multiple-routes/.prettierignore
@@ -1,5 +1,8 @@
 # managed by sku
 *.less.d.ts
+.eslintcache
+.eslintrc
+.prettierrc
 .storybook/main.js
 coverage/
 dist-storybook/

diff --git a/fixtures/public-path/.eslintignore b/fixtures/public-path/.eslintignore
@@ -1,5 +1,8 @@
 # managed by sku
 *.less.d.ts
+.eslintcache
+.eslintrc
+.prettierrc
 .storybook/main.js
 coverage/
 dist-storybook/

diff --git a/fixtures/public-path/.prettierignore b/fixtures/public-path/.prettierignore
@@ -1,5 +1,8 @@
 # managed by sku
 *.less.d.ts
+.eslintcache
+.eslintrc
+.prettierrc
 .storybook/main.js
 coverage/
 dist-storybook/

diff --git a/fixtures/react-css-modules/.eslintignore b/fixtures/react-css-modules/.eslintignore
@@ -1,5 +1,8 @@
 # managed by sku
 *.less.d.ts
+.eslintcache
+.eslintrc
+.prettierrc
 .storybook/main.js
 coverage/
 dist-storybook/

diff --git a/fixtures/react-css-modules/.prettierignore b/fixtures/react-css-modules/.prettierignore
@@ -1,5 +1,8 @@
 # managed by sku
 *.less.d.ts
+.eslintcache
+.eslintrc
+.prettierrc
 .storybook/main.js
 coverage/
 dist-storybook/

diff --git a/fixtures/sku-test/.eslintignore b/fixtures/sku-test/.eslintignore
@@ -1,5 +1,8 @@
 # managed by sku
 *.less.d.ts
+.eslintcache
+.eslintrc
+.prettierrc
 .storybook/main.js
 coverage/
 dist-storybook/

diff --git a/fixtures/sku-test/.prettierignore b/fixtures/sku-test/.prettierignore
@@ -1,5 +1,8 @@
 # managed by sku
 *.less.d.ts
+.eslintcache
+.eslintrc
+.prettierrc
 .storybook/main.js
 coverage/
 dist-storybook/

diff --git a/fixtures/sku-with-https/.eslintignore b/fixtures/sku-with-https/.eslintignore
@@ -1,5 +1,8 @@
 # managed by sku
 *.less.d.ts
+.eslintcache
+.eslintrc
+.prettierrc
 .storybook/main.js
 coverage/
 dist-storybook/

diff --git a/fixtures/sku-with-https/.prettierignore b/fixtures/sku-with-https/.prettierignore
@@ -1,5 +1,8 @@
 # managed by sku
 *.less.d.ts
+.eslintcache
+.eslintrc
+.prettierrc
 .storybook/main.js
 coverage/
 dist-storybook/

diff --git a/fixtures/source-maps/.eslintignore b/fixtures/source-maps/.eslintignore
@@ -1,5 +1,8 @@
 # managed by sku
 *.less.d.ts
+.eslintcache
+.eslintrc
+.prettierrc
 .storybook/main.js
 coverage/
 dist-storybook/

diff --git a/fixtures/source-maps/.prettierignore b/fixtures/source-maps/.prettierignore
@@ -1,5 +1,8 @@
 # managed by sku
 *.less.d.ts
+.eslintcache
+.eslintrc
+.prettierrc
 .storybook/main.js
 coverage/
 dist-storybook/

diff --git a/fixtures/ssr-hello-world/.eslintignore b/fixtures/ssr-hello-world/.eslintignore
@@ -1,5 +1,8 @@
 # managed by sku
 *.less.d.ts
+.eslintcache
+.eslintrc
+.prettierrc
 .storybook/main.js
 coverage/
 dist-build/

diff --git a/fixtures/ssr-hello-world/.prettierignore b/fixtures/ssr-hello-world/.prettierignore
@@ -1,5 +1,8 @@
 # managed by sku
 *.less.d.ts
+.eslintcache
+.eslintrc
+.prettierrc
 .storybook/main.js
 coverage/
 dist-build/

diff --git a/fixtures/storybook-config/.eslintignore b/fixtures/storybook-config/.eslintignore
@@ -1,5 +1,8 @@
 # managed by sku
 *.less.d.ts
+.eslintcache
+.eslintrc
+.prettierrc
 .storybook/main.js
 coverage/
 dist-storybook/

diff --git a/fixtures/storybook-config/.prettierignore b/fixtures/storybook-config/.prettierignore
@@ -1,5 +1,8 @@
 # managed by sku
 *.less.d.ts
+.eslintcache
+.eslintrc
+.prettierrc
 .storybook/main.js
 coverage/
 dist-storybook/

diff --git a/fixtures/styling/.eslintignore b/fixtures/styling/.eslintignore
@@ -1,5 +1,8 @@
 # managed by sku
 *.less.d.ts
+.eslintcache
+.eslintrc
+.prettierrc
 .storybook/main.js
 coverage/
 dist-storybook/

diff --git a/fixtures/styling/.prettierignore b/fixtures/styling/.prettierignore
@@ -1,5 +1,8 @@
 # managed by sku
 *.less.d.ts
+.eslintcache
+.eslintrc
+.prettierrc
 .storybook/main.js
 coverage/
 dist-storybook/

diff --git a/fixtures/translations/.eslintignore b/fixtures/translations/.eslintignore
@@ -1,6 +1,9 @@
 # managed by sku
 **/*.vocab/index.ts
 *.less.d.ts
+.eslintcache
+.eslintrc
+.prettierrc
 .storybook/main.js
 coverage/
 dist-ssr/

diff --git a/fixtures/translations/.prettierignore b/fixtures/translations/.prettierignore
@@ -3,6 +3,9 @@ translations.ts
 # managed by sku
 **/*.vocab/index.ts
 *.less.d.ts
+.eslintcache
+.eslintrc
+.prettierrc
 .storybook/main.js
 coverage/
 dist-ssr/

diff --git a/fixtures/typescript-css-modules/.eslintignore b/fixtures/typescript-css-modules/.eslintignore
@@ -1,5 +1,8 @@
 # managed by sku
 *.less.d.ts
+.eslintcache
+.eslintrc
+.prettierrc
 .storybook/main.js
 coverage/
 dist-storybook/

diff --git a/fixtures/typescript-css-modules/.prettierignore b/fixtures/typescript-css-modules/.prettierignore
@@ -1,5 +1,8 @@
 # managed by sku
 *.less.d.ts
+.eslintcache
+.eslintrc
+.prettierrc
 .storybook/main.js
 coverage/
 dist-storybook/

diff --git a/packages/sku/lib/configure.js b/packages/sku/lib/configure.js
@@ -48,7 +48,6 @@ module.exports = async () => {
     storybookTargetDirectory,
     storybookMainConfigPath,
   ];
-  const lintIgnorePatterns = [...gitIgnorePatterns, '*.less.d.ts'];
 
   // Generate ESLint configuration
   const eslintConfigFilename = '.eslintrc';
@@ -67,6 +66,8 @@ module.exports = async () => {
   });
   gitIgnorePatterns.push(prettierConfigFilename);
 
+  const lintIgnorePatterns = [...gitIgnorePatterns, '*.less.d.ts'];
+
   if (languages) {
     const generatedVocabFileGlob = '**/*.vocab/index.ts';
     gitIgnorePatterns.push(generatedVocabFileGlob);