Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove rimraf dependency in favour of Node.js's rm method #961

Merged
merged 3 commits into from May 8, 2024

Conversation

askoufis
Copy link
Contributor

@askoufis askoufis commented May 7, 2024

Node's rm supports the recursive and force flags, so we don't need rimraf anymore.

Depends on #960 for CI to pass.

EDIT: Hoisting opencollective-postinstall, because who knows why this error is happening.

@askoufis askoufis requested a review from a team as a code owner May 7, 2024 02:07
Copy link

changeset-bot bot commented May 7, 2024

🦋 Changeset detected

Latest commit: b177e8e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
sku Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jahredhope
Copy link
Member

jahredhope commented May 7, 2024

FYI Lint step failed.

@askoufis
Copy link
Contributor Author

askoufis commented May 7, 2024

FYI Lint step failed.

@jahredhope

Depends on #960 for CI to pass.

@askoufis askoufis enabled auto-merge (squash) May 8, 2024 03:55
@askoufis askoufis merged commit 346d53f into master May 8, 2024
4 checks passed
@askoufis askoufis deleted the remove-rimraf branch May 8, 2024 03:56
@seek-oss-ci seek-oss-ci mentioned this pull request May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants