Ensure sku-init test does a thorough cleanup, run it separately to other tests
#962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
askoufis
changed the title
sku-init test does a thorough cleanup, run it separately to the rest of the testssku-init test does a thorough cleanup, run it separately to other tests
askoufis
commented
May 8, 2024
| @@ -3,6 +3,7 @@ module.exports = { | |||
| transform: { | |||
| '^.+\\.(t|j)sx?$': '@swc/jest', | |||
| }, | |||
| maxWorkers: process.env.CI ? 2 : undefined, | |||
There was a problem hiding this comment.
Setting this here as we can no longer pass the flag to pnpm test anymore because that script now runs multiple other scripts.
kjots
approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the same issue that #960 fixes, but now I have a better understanding of the problem, but still not an exact root cause. #960 will still be merged, but just as an update to pnpm v9.
Note
There are some hoisting changes in this PR, in addition to the fix. These were done as an attempt to fix the problem, but didn't actually do anything. I've left them in because they're still worth doing IMO.
The Problem
The
sku-inittest runs the sku CLI'sinitcommand. As part ofsku init, the newly-created app has its dependencies installed. In the past, this has barely modified the lockfile, only adding an entry for thesku-initworkspace package, and nothing else.For some reason, potentially related to peer dependencies, a second
@vanilla-extract/csspackage is now being installed during thesku-inittest. This interferes with style loading in one of thebraid-design-systemtests, probably because thesku-inittest tends to run before thebraid-design-systemsuite in CI.The result is
master(and other branches) tests failing with this error.The Fix
The
sku-inittest file no longer runs alongside all the other tests in thetestsdirectory. Instead, it is run after all the other tests, so as not to affect them. Additionally, the test now runs apnpm installafter completion in order to undo any of the changes to the lockfile/node_modulesit makes. This doesn't matter on CI, but it allows all tests to be run locally without interfering with one another.