Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undo pnpm v9 #964

Closed
wants to merge 1 commit into from
Closed

Undo pnpm v9 #964

wants to merge 1 commit into from

Conversation

askoufis
Copy link
Contributor

@askoufis askoufis commented May 9, 2024

CI is broken in master because #960 was accidentally merged even though the fix it proposed didn't work. This PR is a revert of #960, except for the pnpm setup action update.

EDIT: Seems fixed for now, will keep PR open though.

@askoufis askoufis requested a review from a team as a code owner May 9, 2024 03:55
Copy link

changeset-bot bot commented May 9, 2024

⚠️ No Changeset found

Latest commit: a15594a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@askoufis askoufis changed the title Undo pnpm v9, don't hoist opencollective-postinstall Undo pnpm v9 May 9, 2024
@askoufis
Copy link
Contributor Author

The error seems to have fixed itself as of today. Going to keep this PR open for now, as I'm skeptical that the fix is permanent.

@askoufis askoufis closed this May 15, 2024
@askoufis askoufis deleted the pnpm9-was-a-mistake branch May 15, 2024 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant