Allow skuba configure to accept stdin input
#1558
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: be04fc5 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
samchungy
changed the title
skuba configure to take in stdin inputskuba configure to accept stdin input
72636c
approved these changes
May 9, 2024
| log.plain(log.bold(packageManager, 'install')); | ||
| log.plain(log.bold(packageManager, 'run', 'format')); | ||
| log.plain(log.bold(packageManager.install)); | ||
| log.plain(log.bold(packageManager.exec, 'format')); |
There was a problem hiding this comment.
Is this right? IIRC, pnpm exec is for .bins and pnpm run is for package.json scripts.
Alternatively maybe we can simplify to just pnpm if that's reliable.
| 'skuba': minor | ||
| --- | ||
|
|
||
| configure: Now accepts template data from stdin to allow for integration testing |
There was a problem hiding this comment.
Suggested change
| configure: Now accepts template data from stdin to allow for integration testing | |
| configure: Accept template data from stdin to allow for integration testing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need this to run some tests in my test template repo.