Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add native web module for Android #15

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

alekspickle
Copy link

I stumbled upon one issue, that Android was just unable to render what I wanted to, while iOS was definately happy with RN WebView, So I was able to increase performance of Android device with another great lib! I thought you could include this. Your call anyway))

P.S. by the way, thank you for great library!

@seekshiva
Copy link
Owner

Thanks for the PR. Sorry in the delay in getting to reviewing this.

react-native-webview-android has native dependencies, and all the projects I have are built on top of Expo platform and can only be pure JS. So bringing in a native module is not an option for me.

I'm curious about how much perf improvements this library brings over the WebView that comes with react-native. Can you provide some stats on that? Will consider merging this change in if the perf improvement is very drastic.

Thanks

@alekspickle
Copy link
Author

alekspickle commented Jul 31, 2018

I had somewhat specific goal to work (imho) unnecessary complex SVG as avatar pics (with shades and stuff). So without this native webview on Android it was absolutely impossible to debug or use app, because of delays near 20s after each avatar part change.
What I have been done is absolute sin and I wouldn't recommend to do that, but again - I had a task and there wasn't neither obvious nor any good solution whatsoever.

As for numbers.
I did improved render time in 5-6 times on Android (maybe more, I mean now it at least seems to be not worse than any Instagram lags) and haven't found any solution for those horribly complex SVG on iOS.
But as for using SVG in native you are absolutely great, I have no doubt that it would work with reasonable usage👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants