Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update svg rendering approach #45

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update svg rendering approach #45

wants to merge 2 commits into from

Conversation

tarik02
Copy link

@tarik02 tarik02 commented May 28, 2019

Normally svg is rendered using backgroundImage in web.

@seekshiva
Copy link
Owner

How is this better than rendering the svg directly in DOM?

@tarik02
Copy link
Author

tarik02 commented Jun 4, 2019

@seekshiva now svg always cover the whole webview.

@seekshiva
Copy link
Owner

The height: 100%; width: 100% that was assigned to svg tag also ensured that the svg covered the whole webview. Was there any scenario where it wasn't covering the WebView fully?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tarik02 @seekshiva