Pass all props to webview #52
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pass all props to the WebView before setting the specific WebView props required by react-native-remote-svg. The `baseUrl` added to the `source` prop fixed an issue where iOS does not fire the `onLoad...` events. This also means that the calls to `onLoadStart` and 'onLoadEnd' can be removed, as they will be delegated to the WebView.
|
Details of the onLoad... issue on iOS are available at facebook/react-native#18802 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pass all props to the WebView before setting the specific WebView props required by react-native-remote-svg.
The
baseUrladded to thesourceprop fixed an issue where iOS does not fire theonLoad...events. This also means that the calls toonLoadStartand 'onLoadEnd' can be removed, as they will be delegated to the WebView.