Stratconn 2695 eliminate 403 missing scopes errors #1432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| perform: (request, { payload, settings }) => { | ||
| perform: async (request, { payload, settings, auth }) => { | ||
| let response | ||
| try { |
There was a problem hiding this comment.
@hvardhan-unth - I don't think its a good idea to add another API call to validate scope. The API call should be a one time activity when the customer sets up the destination. Could we do it differently?
There was a problem hiding this comment.
Yes, Now we are getting scopes from settings instead of calling extra API.
marinhero
requested changes
Jul 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Over the last 30 days, 1.3% of the app's API calls (2M) resulted in 403 errors. All of these are due to some 59 portals missing the analytics.behavioral_events.send scope necessary to access the Custom Behavioral Events API (POST /events/v3/send). So, in this PR applied check on access-token for a scope for Custom behavioural event action when user perform the action.
JIRA ticket link:- https://segment.atlassian.net/browse/STRATCONN-2695
Testing
Include any additional information about the testing you have completed to
ensure your changes behave as expected. For a speedy review, please check
any of the tasks you completed below during your testing.