Plugin.ready now returns correct promise #1541
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously Plugin.ready would simply return Promise.resolve() just so the "waterfall" like flow of analytics and other compoenents won't come hold up, potentially indefintely. However, the recent architecture changes to ajs where destinations are loaded in lazy mode require ready to report their real readiness status since indefinite hold up is no longer a concern. This change to Plugin.ready has been unanimously discussed across Pooya Jaferian, Oscar Bazaldua, Seth Silesky
joe-ayoub-segment
added
not-partner-eng-review (device)
and removed
not-partner-eng-review (cloud)
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously Plugin.ready would simply return Promise.resolve() just so the "waterfall" like flow of analytics and other compoenents won't come hold up, potentially indefintely.
However, the recent architecture changes to ajs where destinations are loaded in lazy mode require ready to report their real readiness status since indefinite hold up is no longer a concern.
This change to Plugin.ready has been unanimously discussed across Pooya Jaferian, Oscar Bazaldua, Seth Silesky