[Stratconn-2879] | Set up DataDog dashboard to track requests to Oauth Supported Destinations. #1585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
varadarajan-tw
previously approved these changes
Sep 25, 2023
packages/destination-actions/src/destinations/airship/utilities.ts
Outdated
Show resolved
Hide resolved
|
@Innovative-GauravKochar Thank you for putting all this together! After seeing how many changes oauth metrics tracking entails, I think I'd prefer to extract LinkedIn into its own PR and merge/deploy that first so we limit the blast radius of the change. Once we get signal on how useful metrics are for LinkedIn, then we can move forward with adding metrics to the other destinations. @Innovative-GauravKochar is it possible to set up a PR with only the changes to LinkedIn sometime this week? Thank you again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull request is to set up DataDog dashboard to track requests to Oauth Supported Destinations.
Jira Ticket:- https://segment.atlassian.net/jira/software/c/projects/STRATCONN/boards/310?modal=detail&selectedIssue=STRATCONN-2879&assignee=63617339fc0cc7a600b03c6b
Testing
Include any additional information about the testing you have completed to
ensure your changes behave as expected. For a speedy review, please check
any of the tasks you completed below during your testing.