Refreshing access token logic for get/createAudience #1767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nick-Ag
commented
Dec 7, 2023
nick-Ag
changed the title
|
Paused on this one until Jan 2024 |
celine-liew
reviewed
Jan 8, 2024
| // Copied from onSubscriptions -> I don't think this options object will have the onTokenRefresh function... | ||
|
|
||
| if (options) { | ||
| await options?.onTokenRefresh?.(newTokens) |
There was a problem hiding this comment.
should you do a try / catch here if it's possible to get error onTokenRefresh?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates
getAudienceandcreateAudienceto use similar retry logic as regular streaming events when an invalid access token error occurs.Testing
Include any additional information about the testing you have completed to
ensure your changes behave as expected. For a speedy review, please check
any of the tasks you completed below during your testing.