Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more Fullstory settings #1918

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

dja
Copy link

@dja dja commented Mar 8, 2024

Adds other Fullstory settings for configuring the fullstory-browser-sdk to allow for custom domain specification and other features supported by the SDK.
https://github.com/fullstorydev/fullstory-browser-sdk?tab=readme-ov-file#initialize-the-sdk
https://help.fullstory.com/hc/en-us/articles/18612999473175-How-to-send-captured-traffic-to-FullStory-using-Custom-Endpoints

Testing

Include any additional information about the testing you have completed to
ensure your changes behave as expected. For a speedy review, please check
any of the tasks you completed below during your testing.

  • Added unit tests for new functionality
  • Tested end-to-end using the local server
  • [Segmenters] Tested in the staging environment

@joe-ayoub-segment
Copy link
Contributor

hi @dja - thanks for raising this PR.
Is there code missing from the PR? All I see are some added Setting definitions, but the logic to make use of those definitions is missing from the code.
Can you please check / clarify?
Kind regards,
Joe

@dja
Copy link
Author

dja commented Mar 11, 2024

hi @dja - thanks for raising this PR. Is there code missing from the PR? All I see are some added Setting definitions, but the logic to make use of those definitions is missing from the code. Can you please check / clarify? Kind regards, Joe

Hi Joe,
This is my first time contributing to the codebase and wasn't able to generate types or find anywhere else to setup the browser destination for the new settings definitions. Do you have any recommendations on what else is needed?

Thanks!

@joe-ayoub-segment
Copy link
Contributor

joe-ayoub-segment commented Mar 11, 2024 via email

@joe-ayoub-segment
Copy link
Contributor

hi @dja - just checking if this PR is something you still want to proceed with?

@dja
Copy link
Author

dja commented Mar 25, 2024

hi @dja - just checking if this PR is something you still want to proceed with?

Thanks for checking Joe - I think it'd be better if someone else took this on. For now, we've applied a monkey patch on our end to circumvent the limitation.

@joe-ayoub-segment
Copy link
Contributor

Thanks @dja - who's the best person to follow up with?

@dja
Copy link
Author

dja commented Mar 27, 2024

I believe an engineer from Fullstory has reached out to your team?

@joe-ayoub-segment
Copy link
Contributor

I believe an engineer from Fullstory has reached out to your team?

Hi @dja - I don't believe that anyone has been in touch. Is there someone you can connect me with please? my email is jayoub@twilio.com

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants