Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hide event context field for mixpanel #2010

Merged
merged 1 commit into from May 21, 2024
Merged

Conversation

tcgilbert
Copy link
Contributor

This comes at the request of Mixpanel:

Hi all!

This is Donna from Mixpanel's Support Team.

I wanted to reach out regarding Mixpanel Actions Destination Mappings: https://segment.com/docs/connections/destinations/catalog/actions-mixpanel/

We are seeing that customers are confused by the "Event Context" that is shown in Track Calls.

Customers see that mapping, and they are confused as to why Mixpanel does not attach all of "event context" data to their Mixpanel Events.

With the Destination, we are only taking certain data from the Event Context (as Context is not a concept in Mixpanel) so I wanted to ask if we could hide this mapping in the UI for Mixpanel Actions?
image.png

We've also previously brought this up in the shared Slack channel we have (#segment_mixpanel_integration) if you'd like to continue the conversation via Slack.

I can't think of a use case for exposing this, other than if a user wants to NOT pass any context details. So open to discussion on this.

@joe-ayoub-segment
Copy link
Contributor

Hi @tcgilbert ,
How is the data from the context field actually being processed in the perform() function? Are parts of it used and others discarded?

@tcgilbert
Copy link
Contributor Author

How is the data from the context field actually being processed in the perform() function? Are parts of it used and others discarded?

@joe-ayoub-segment so this property is imported into trackEvent and trackPurchase, but ultimately it gets parsed in the same function getEventProperties. Within this function, the only property that is being pulled from context is payload.context?.integration if it exists.

That being the case, I'd say the need for this field is a bit overkill in the first place.

@joe-ayoub-segment joe-ayoub-segment merged commit a88ef6b into main May 21, 2024
11 checks passed
@joe-ayoub-segment joe-ayoub-segment deleted the thomas/mixpanel branch May 21, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants