New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add external_id field to trackEvent Action #2011
base: main
Are you sure you want to change the base?
Conversation
external_id: { | ||
label: 'External ID', | ||
type: 'string' | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like a straightforward change. Just a few questions:
-
Does adding support for external_id break with any conventions in other Actions? e.g. does another Action also support external_id, but maybe have it named or handled differently?
-
Should there be default mappings for the external_id (and maybe also phone_number and email ) field?
-
Has this been end to end tested some how? Has it been confirmed that the external_id gets to Klaviyo correctly?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does adding support for external_id break with any conventions in other Actions? e.g. does another Action also support external_id, but maybe have it named or handled differently?
No. All the other actions actually have an external_id field, so if anything this makes the actions more congruent.
Should there be default mappings for the external_id (and maybe also phone_number and email ) field?
Can you add default mappings to properties within a object type? If so, I think this would make sense
Has this been end to end tested some how? Has it been confirmed that the external_id gets to Klaviyo correctly?
I've been sending events from Actions tester to Klaviyo, and can verify that the external_id is arriving within klaviyo. If there is any other way to test, happy to do so as well. Here is one for "Order Completed", external_id was empty previsouly
This update adds the ability to map a Segment field to Klaviyo's external_id in their create event api.
This comes at the request of the Klaviyo team:
Testing
Tested locally: