1flow web sdk event update #2019
Conversation
For the development purpose we were using the development URL but forgot to update it when we moved to live env so updating this so can test it out for beta mode as the destination is provided by the segment team already.
| @@ -43,7 +34,7 @@ const action: BrowserActionDefinition<Settings, _1Flow, Payload> = { | |||
| type: 'string', | |||
| required: false, | |||
| default: { | |||
| '@path': '$.traits.first_name' | |||
| '@path': '$.first_name' | |||
There was a problem hiding this comment.
hi @namit1Flow - a customer will never place first_name at this location in the payload. In an identify() call it will always be in traits.first_name.
What's the rationale for changing this?
There was a problem hiding this comment.
You’re correct, fixed it please check
packages/browser-destinations/destinations/1flow/src/identifyUser/index.ts
Outdated
Show resolved
Hide resolved
packages/browser-destinations/destinations/1flow/src/identifyUser/index.ts
Outdated
Show resolved
Hide resolved
packages/browser-destinations/destinations/1flow/src/identifyUser/index.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
hi @namit1Flow thanks for raising this PR.
Only query I have is related to the change in mapping paths. Please see inline comments.
|
Hi @namit1Flow I'm going to be on leave until 16-May. Is deploying this PR urgent? Is it OK to wait until I get back to deploy this? cc @tcgilbert |
|
Hi @joe-ayoub-segment , Currently one of our internal customers is waiting for these changes so if possible would you be able to deploy these changes asap ? |
FYI @pooyaj and @tcgilbert ^ |
|
@joe-ayoub-segment @tcgilbert When should I expect it to be deployed? |
|
hi @namit1Flow The PR is good to deploy - however the company has mandated a deploy freeze due to an ongoing internal issue. |
|
hi @namit1Flow this PR has been deployed. Can you confirm that you are happy with the changes please? |
Updates