New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MAIN] [STRATCONN] added consent for google campaign manager #2021
Conversation
50a0b09
to
41e2901
Compare
Hey @danieljackins, Changed size-limit from 151 KB to 152 KB because builds are failing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ✨
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice Work @AnkitSegment ,Looks good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Just a minor comment regrading tests.
] | ||
|
||
describe('Google Tag for Campaign Manager', () => { | ||
const defaultSettings = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you also pls add a test for enableConsentMode
not being set?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added.
57f5c85
hi @AnkitSegment PR deployed |
Added consent mode settings for google campaign manager
JIRA TICKET: https://segment.atlassian.net/browse/STRATCONN-3789
Action Tester:
Segment App:
GTAG manager:
Chrome console:
A summary of your pull request, including the what change you're making and why.
Testing
Include any additional information about the testing you have completed to
ensure your changes behave as expected. For a speedy review, please check
any of the tasks you completed below during your testing.