Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAIN] [STRATCONN] added consent for google campaign manager #2021

Merged
merged 7 commits into from May 21, 2024

Conversation

AnkitSegment
Copy link
Contributor

@AnkitSegment AnkitSegment commented May 2, 2024

Added consent mode settings for google campaign manager

JIRA TICKET: https://segment.atlassian.net/browse/STRATCONN-3789

Action Tester:

Screenshot 2024-05-02 at 3 27 47 PM

Segment App:

Screenshot 2024-05-10 at 2 06 02 PM

GTAG manager:

Screenshot 2024-05-10 at 2 03 05 PM

Chrome console:

Screenshot 2024-05-10 at 2 04 56 PM

A summary of your pull request, including the what change you're making and why.

Testing

Include any additional information about the testing you have completed to
ensure your changes behave as expected. For a speedy review, please check
any of the tasks you completed below during your testing.

  • Added unit tests for new functionality
  • Tested end-to-end using the local server
  • [Segmenters] Tested in the staging environment

@AnkitSegment
Copy link
Contributor Author

Hey @danieljackins, Changed size-limit from 151 KB to 152 KB because builds are failing.

Screenshot 2024-05-10 at 2 30 53 PM

harsh-joshi99
harsh-joshi99 previously approved these changes May 10, 2024
Copy link
Contributor

@harsh-joshi99 harsh-joshi99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✨

Copy link
Contributor

@Innovative-GauravKochar Innovative-GauravKochar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice Work @AnkitSegment ,Looks good to me

Copy link
Contributor

@varadarajan-tw varadarajan-tw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just a minor comment regrading tests.

]

describe('Google Tag for Campaign Manager', () => {
const defaultSettings = {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you also pls add a test for enableConsentMode not being set?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added.

@joe-ayoub-segment joe-ayoub-segment merged commit 95d36fe into main May 21, 2024
11 checks passed
@joe-ayoub-segment joe-ayoub-segment deleted the STRATCONN-3789-consent-GCM branch May 21, 2024 15:27
@joe-ayoub-segment
Copy link
Contributor

hi @AnkitSegment PR deployed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants