[Salesforce] Alternative authentication flow #2023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ow is attempted and the username+password flow is tried if that fails
…ing undefined, fixes build
…rated access tokens. No Build
…l when authenticating
…ent ID and secret to pull from chamber
…xed verion, which doesn't exist
… uses security_token field to construct password sent to salesforce, updates descriptions
nick-Ag
changed the title
marinhero
requested changes
May 6, 2024
packages/destination-actions/src/destinations/salesforce/sf-operations.ts
Show resolved
Hide resolved
packages/destination-actions/src/destinations/salesforce/sf-operations.ts
Show resolved
Hide resolved
marinhero
approved these changes
May 7, 2024
marinhero
requested changes
May 7, 2024
marinhero
approved these changes
May 15, 2024
|
@varadarajan-tw or @joe-ayoub-segment To whoever deploys this, I will handle the |
|
@nick-Ag said this is OK to deploy |
|
hi @nick-Ag PR deployed! Not pushed as requested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds authentication using username & password to Salesforce. This was requested by a customer and the functionality will be locked to that customer. See the ticket for more info: https://segment.atlassian.net/browse/STRATCONN-3682
Prior to creating the Salesforce client we will request an authentication token from Salesforce using the username + password if they are defined in the settings. This token will be used for all requests made from the request client.
Related PR: https://github.com/segmentio/app/pull/20349
Testing
Tested successfully in staging, the username+password flow is used correctly and events are delivered.
In event tester the access token request using username + password can be seen by the user:
Subsequent requests using that token succeed:
