Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Heap - update property flattening on browserArrayLimit in track call #2028

Merged
merged 1 commit into from May 21, 2024

Conversation

jessi-heap
Copy link
Contributor

Updated flattening logic

  • when browserArrayLimit is set, it should still flatten objects outside of arrays
  • added test should flatten properties on parent when browserArrayLimit is set shows an example of this case (objects are dropped in heap so we flatten here to retain the information)
  • updated stringify logic - this was inconsistent
  • removed the logic to remove the top level name from the key (should be custom_vars.xxx instead of xxx)

Testing

Include any additional information about the testing you have completed to
ensure your changes behave as expected. For a speedy review, please check
any of the tasks you completed below during your testing.

  • Added unit tests for new functionality
  • Tested end-to-end using the local server
  • [Segmenters] Tested in the staging environment

@tcgilbert
Copy link
Contributor

hi @jessi-heap - our partner engineer who reviews these PRs is currently out of office but will be back Thursday. If there is absolute urgency behind this PR, or you have any questions, let me know.

@joe-ayoub-segment joe-ayoub-segment merged commit 950be33 into segmentio:main May 21, 2024
10 of 11 checks passed
@joe-ayoub-segment
Copy link
Contributor

hi @jessi-heap this PR has been deployed. Can you confirm that you are happy with the changes please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants