Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UserMotion] Improvements #2029

Merged
merged 1 commit into from May 21, 2024
Merged

[UserMotion] Improvements #2029

merged 1 commit into from May 21, 2024

Conversation

namirali
Copy link
Contributor

Bug fixed that prevented to run PageView properly. Also some API improvements like passing $.context

Testing

  • Added unit tests for new functionality
  • Tested end-to-end using the local server
  • [Segmenters] Tested in the staging environment

@tcgilbert
Copy link
Contributor

hi @namirali - our partner engineer who reviews these PRs is currently out of office but will be back Thursday. If there is absolute urgency behind this PR, or you have any questions, let me know.

@joe-ayoub-segment joe-ayoub-segment self-assigned this May 16, 2024
@joe-ayoub-segment
Copy link
Contributor

image

@joe-ayoub-segment joe-ayoub-segment merged commit 0ad30f3 into segmentio:main May 21, 2024
10 of 11 checks passed
@joe-ayoub-segment
Copy link
Contributor

hi @namirali this PR has been deployed. Please confirm the change looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants