Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Pass valueToSum correctly to the Facebook SDK #936

Conversation

gbyesiltas
Copy link
Contributor

Changes list

  • The _valueToSum attribute is mapped to properties however the logEvent method gets valueToSum from the second argument

Demo instructions
Using this plugin, send an event with the price or value field. You should see that value in the _valueToSum field in the corresponding Facebook event

@alanjcharles alanjcharles merged commit 5e164ca into segmentio:master May 20, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants