Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node Issue #309 #2592

Merged
merged 6 commits into from
Mar 16, 2022
Merged

Node Issue #309 #2592

merged 6 commits into from
Mar 16, 2022

Conversation

nd4p90x
Copy link
Contributor

@nd4p90x nd4p90x commented Mar 10, 2022

Proposed changes

Add new explanations regarding Long & Short Lived processes and how to properly utilize the API with each

Merge timing

  • ASAP once approved

Related issues (optional)

segmentio/analytics-node#309

@nd4p90x nd4p90x requested a review from a team as a code owner March 10, 2022 21:52
@nd4p90x nd4p90x requested review from rchinn1 and removed request for a team March 10, 2022 21:52
Copy link
Contributor

@rchinn1 rchinn1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this @nd4p90x!
I'm not able to edit this pr, so just a few minor requests, and I'll be sure to get this in our docs deploy next Tuesday.

nd4p90x and others added 3 commits March 16, 2022 12:42
Co-authored-by: rchinn-segment <93161299+rchinn-segment@users.noreply.github.com>
Co-authored-by: rchinn-segment <93161299+rchinn-segment@users.noreply.github.com>
Co-authored-by: rchinn-segment <93161299+rchinn-segment@users.noreply.github.com>
@nd4p90x nd4p90x requested a review from rchinn1 March 16, 2022 17:50
@rchinn1 rchinn1 merged commit 1be14c4 into segmentio:develop Mar 16, 2022
@github-actions
Copy link
Contributor

Thank you for your contribution! Your pull request is merged, but may take a day or two to appear on the site.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants