Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use new corvu type system and separate packages #90

Closed
wants to merge 0 commits into from

Conversation

GiyoMoon
Copy link
Contributor

Updates the corvu components to use the new type system and import them from the separated packages.

(I also had to update your tsconfig files to use "moduleResolution": "bundler" instead of node because corvu only builds for esm and node is an outdated cjs resolution strategy. Read more here: https://www.typescriptlang.org/tsconfig/#moduleResolution

Copy link

changeset-bot bot commented May 13, 2024

⚠️ No Changeset found

Latest commit: d638f1b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented May 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
solid-ui-components ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 14, 2024 9:32pm

@GiyoMoon
Copy link
Contributor Author

@sek-consulting I updated the PR to use generic components :) I'm going to release an update to corvu tomorrow which fixes the current type errors that are present. (See the drawer-demo.tsx file for example)
I'll update the PR and set it to ready for review once I'm done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant