Skip to content

Commit

Permalink
Update grunt-contrib-qunit to latest version (#5530)
Browse files Browse the repository at this point in the history
We needed to define the `qunit` module in the unit tests because there was a change in grunt-contrib-qunit 0.6.0 that breaks when you define an AMD loader. It expects that the AMD loader is also used to load QUnit, instead of just being used to support the tests, so if you don't define the qunit module it will just hang and do nothing. Luckily we have the helpers file to help us out here, since it allows us to globally define this module.
  • Loading branch information
kevin-brown committed Jun 5, 2019
1 parent 70ca392 commit 5d2fdd7
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 1 deletion.
2 changes: 1 addition & 1 deletion package.json
Expand Up @@ -53,7 +53,7 @@
"grunt-contrib-concat": "^1.0.1",
"grunt-contrib-connect": "^2.0.0",
"grunt-contrib-jshint": "^1.1.0",
"grunt-contrib-qunit": "^0.5.2",
"grunt-contrib-qunit": "^1.3.0",
"grunt-contrib-requirejs": "^1.0.0",
"grunt-contrib-uglify": "~4.0.1",
"grunt-contrib-watch": "~1.1.0",
Expand Down
4 changes: 4 additions & 0 deletions tests/helpers.js
Expand Up @@ -44,3 +44,7 @@ QUnit.testStart(function(testDetails){
}
});
});

define('qunit', function () {
return QUnit;
})

0 comments on commit 5d2fdd7

Please sign in to comment.