Enter key still works on disabled select when ID is set

[Pompiedom]

Prerequisites

• I have searched for similar issues in both open and closed tickets and cannot find a duplicate
• The issue still exists against the latest master branch of Select2
• This is not a usage question (Those should be directed to the community)
• I have attempted to find the simplest possible steos to reproduce the issue
• I have included a failing test as a pull request (Optional)

Steps to reproduce the issue

1. Create a select with the "disabled" attribute
2. Init select2
3. Click with the mouse on the disabled select
4. Press the enter key
5. The dropdown doesn't open
6. Create a select with the "disabled" attribute and add an id attribute e.g. "id='test'"
7. Click with the mouse on the disabled select
8. Press the enter key
9. The dropdown does open

Expected behavior and actual behavior

When I follow those steps, I see the dropdown open on a disabled select, that should never be possible.

Environment

Browsers

• Google Chrome
• Mozilla Firefox
• Internet Explorer 11

Operating System

• Windows
• Mac OS X
• Linux
• Mobile

Libraries

• jQuery version: 1.9.1
• Select2 version: 4.0.3

Isolating the problem

• This bug happens on the examples page
• The bug happens consistently across all tested browsers
• This bug happens when using Select2 without other pluigns
• I can reproduce this bug in [a jsbin] https://jsfiddle.net/pompiedom/wz9uLehv/3/

[esl-douglas]

Still a bug.

I made a temporary fix.
$(document).on('select2:opening.disabled', ':disabled', function() { return false; })

[ericmdantas]

Yup, also happened to me.

@esl-douglas's fix seems to do the trick. Thanks!

[ericmdantas]

By the way, these lines seem to be the ones forcing the opening:

select2/src/js/select2/core.js

Lines 319 to 353 in 062c6c3

	this.on('keypress', function (evt) {
	var key = evt.which;
	if (self.isOpen()) {
	if (key === KEYS.ESC || key === KEYS.TAB ||
	(key === KEYS.UP && evt.altKey)) {
	self.close();
	evt.preventDefault();
	} else if (key === KEYS.ENTER) {
	self.trigger('results:select', {});
	evt.preventDefault();
	} else if ((key === KEYS.SPACE && evt.ctrlKey)) {
	self.trigger('results:toggle', {});
	evt.preventDefault();
	} else if (key === KEYS.UP) {
	self.trigger('results:previous', {});
	evt.preventDefault();
	} else if (key === KEYS.DOWN) {
	self.trigger('results:next', {});
	evt.preventDefault();
	}
	} else {
	if (key === KEYS.ENTER || key === KEYS.SPACE ||
	(key === KEYS.DOWN && evt.altKey)) {
	self.open();
	evt.preventDefault();
	}
	}
	});

Maybe just checking the state of the select should do the trick?

[alexweissman]

Sure, want to make the fix, write up a few tests, and submit a PR?

Looks like in other parts of the codebase, we use some simple logic to return early when the control is disabled:

select2/src/js/select2/core.js

Lines 448 to 450 in 062c6c3

	if (this.options.get('disabled')) {
	return;
	}

[Doolan]

This issue also exists in the examples app.
https://select2.org/appearance

Clicking on the disabled dropdown and hitting the space key will allow the user to chose a new option and change the value of the dropdown.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[JonBetts]

This still seems to be an issue in 4.0.5. I'm surprised more people haven't reported it!

[fr0z3nfyr]

Any plans to close this in next release?

I guess this is where the test has to be made and return false (on master)

select2/src/js/select2/core.js

Lines 348 to 355 in 04fce55

	} else {
	if (key === KEYS.ENTER || key === KEYS.SPACE ||
	(key === KEYS.DOWN && evt.altKey)) {
	self.open();
	evt.preventDefault();
	}
	}

[VpocopocoV]

For anyone using select2.full.min.js, you may search for "a.open" and replace that part of the code with the one below:

this.options.get("disabled") ? b.preventDefault() : a.open()

This will inspect if the select2 element is disabled and prevent any further action.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[paxnovem]

I am going to reopen this issue for another stale cycle.

[kevin-brown]

This was fixed in 4.0.13 by #5751.