Do not propagate click when search box is not empty #5580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a long-standing bug where if you tried to click in the search box for a multiple select while there was text in it, the dropdown would close and the text would be cleared. This caused many unexpected issues, because it meant that you could only use your keyboard to edit text within the search box. This will still clear out the search field if you click within the area of the selection which is not the search field. I'm not sure if that is also unexpected behaviour, so for now I am going to maintain it. Fixes #3517 Fixes #3808 Fixes #5491 Closes #5551
This was referenced Apr 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes a
The following changes were made
If this is related to an existing ticket, include a link to it as well.
Fixes #3517
Fixes #3808
Fixes #5491
Closes #5551