Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not propagate click when search box is not empty #5580

Merged
merged 1 commit into from Jul 21, 2019
Merged

Commits on Jul 21, 2019

  1. Do not propagate click when search box is not empty

    This fixes a long-standing bug where if you tried to click in the
    search box for a multiple select while there was text in it, the
    dropdown would close and the text would be cleared. This caused
    many unexpected issues, because it meant that you could only use
    your keyboard to edit text within the search box.
    
    This will still clear out the search field if you click within the
    area of the selection which is not the search field. I'm not sure
    if that is also unexpected behaviour, so for now I am going to
    maintain it.
    
    Fixes #3517
    Fixes #3808
    Fixes #5491
    Closes #5551
    kevin-brown committed Jul 21, 2019
    Copy the full SHA
    e56a8f3 View commit details
    Browse the repository at this point in the history