Fixed bug with deselecting items in grouped multiple select when data ids are not strings #3883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… when data ids are not strings
Jivings
changed the title
|
I think this was fixed in the latest master, because the issue previously was that we were not setting the normalized data object on the In any case, a failing test case would be useful so we can try to prevent this from regressing in the future. |
|
@kevin-brown Here's my failing codepen on v4.0.0, I'll try and get around to writing a proper test. |
added 2 commits
November 4, 2015 17:55
|
This has been corrected in one of the previous versions as we are now forcing ids to be strings wherever we find them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3882