Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix AJAX data source error #4356

Closed
wants to merge 4 commits into from
Closed

Fix AJAX data source error #4356

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e482efe
Fix AJAX data source error
MichaelMackus May 11, 2016
2ee3542
Update dist files with bugfix
MichaelMackus May 11, 2016
6502b40
Revert changes to dist dir
MichaelMackus Feb 20, 2017
180d366
Check for string value
MichaelMackus Feb 20, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion dist/js/select2.full.js
View file
Open in desktop
Expand Up @@ -3444,7 +3444,7 @@ S2.define('select2/data/ajax',[
}, function () {
// Attempt to detect if a request was aborted
// Only works if the transport exposes a status property
if ($request.status && $request.status === '0') {
if ('status' in $request && $request.status === 0) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this not going to break support for all browsers that have '0' ? shouldnt this be $request.status === 0 || $request.status === '0'?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For those who are using timeout : if ('status' in $request && $request.status === 0 && $request.statusText != "timeout")

return;
}

Expand Down
2 changes: 1 addition & 1 deletion dist/js/select2.js
View file
Open in desktop
Expand Up @@ -3444,7 +3444,7 @@ S2.define('select2/data/ajax',[
}, function () {
// Attempt to detect if a request was aborted
// Only works if the transport exposes a status property
if ($request.status && $request.status === '0') {
if ('status' in $request && $request.status === 0) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't change dist files, for more info check CONTRIBUTING

return;
}

Expand Down
2 changes: 1 addition & 1 deletion src/js/select2/data/ajax.js
View file
Open in desktop
Expand Up @@ -82,7 +82,7 @@ define([
}, function () {
// Attempt to detect if a request was aborted
// Only works if the transport exposes a status property
if ($request.status && $request.status === '0') {
if ('status' in $request && $request.status === 0) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same question.

return;
}

Expand Down