Better detection of aborted ajax queries #4462
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Chrome 50, `$request.status` is a number, not a string thus the aborted query detection failed. For the end-user this resulted in seeing the 'The results could not be loaded.' message when he typed too fast for too long, instead of the correct 'Searching…' message. This commit check `$request.status` both as a number and as a string, keeping backward compatibility while fixing the case for Chrome.
|
This is a duplicate of #4356, which is going to be pulled in for 4.1.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes a
The following changes were made:
On Chrome 50,
$request.statusis a number, not a string thus the aborted query detection failed. For the end-user this resulted in seeing the 'The results could not be loaded.' message when he typed too fast for too long, instead of the correct 'Searching…' message.This commit check
$request.statusboth as a number and as a string, keeping backward compatibility while fixing the case for Chrome.