Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: #4870 — fixed response status check #4882

Closed

Conversation

eternalfame
Copy link

refer to #4870

@acolchagoff
Copy link
Contributor

your fix doesn't consider if status is undefined, I think it needs to be:

if ($request.status && ($request.status === 0 || $request.status === '0')) {

@alexweissman
Copy link
Contributor

This appears to be a duplicate of #4356. Please contribute to that PR, if possible. It really just needs someone to write a few tests and then it can get merged in!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants