Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for issue #4632 #5093

Closed
wants to merge 1 commit into from
Closed

Fix for issue #4632 #5093

wants to merge 1 commit into from

Conversation

julianyus
Copy link
Contributor

This pull request includes a

  • [ x ] Bug fix
  • New feature
  • Translation

The following changes were made

  • I have changed the way in which an item is determined to be a simple object
  • I have created some tests to verify that a user-defined object is correctly normalized

Issue: #4632

@alexweissman alexweissman added this to the 4.0.5 milestone Oct 25, 2017
@alexweissman
Copy link
Contributor

Nice! I'm hoping to get a release candidate out for 4.0.5 soon.

@alexweissman
Copy link
Contributor

@julianyus it looks like the last two assertions in select-tests are failing for me in Firefox:

screen shot 2017-10-25 at 1 46 19 pm

Seems like normalizedItem3.id and normalizedItem3.text are returning objects, not scalars.

@julianyus
Copy link
Contributor Author

@alexweissman
To me it works in firefox.
Did you do "grunt compile"? I did not include the compiled files (dist folder) in the commit.

@alexweissman
Copy link
Contributor

Did you do "grunt compile"?

d'oh! Thanks, I always forget that the tests are pulling from dist/ ☹️

Ok this looks good, I'll put it out in the RC.

alexweissman added a commit that referenced this pull request Oct 25, 2017
@alexweissman alexweissman modified the milestones: 4.0.5, 4.0.6 Oct 25, 2017
@alexweissman
Copy link
Contributor

Merged into develop for 4.0.6 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants