Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compatibility with jquery-3.4.0 #5524

Closed
wants to merge 1 commit into from

Conversation

borisson
Copy link

See issue #5485

This pull request includes a

  • Bug fix
  • New feature
  • Translation

If this is related to an existing ticket, include a link to it as well.
#5485

@mkutlu
Copy link

mkutlu commented May 31, 2019

This was not solved problem for IE, it just work for chrome.

@blikblum
Copy link
Contributor

blikblum commented Jun 1, 2019

This was not solved problem for IE, it just work for chrome.

I tested with IE 11 and is working

@kevin-brown
Copy link
Member

Hi there, and thanks for the pull request to Select2.

Since this is fixing something which has already broken, we prefer it if the pull request includes a failing test case. With a failing test case, we don't need to worry about breaking this specific case again in the future, which saves us all a lot of time and trouble.

@kevin-brown kevin-brown added the 4.x label Jun 5, 2019
@borisson
Copy link
Author

borisson commented Jun 5, 2019

@kevin-brown I'm sorry - I won't be able to include a testcase. We've since switched to a different library so I won't get company time and I maintain my own project(s) so most of my limited free time goes to that. I understand why you'd want a test - sorry I won't be able to provide that.

@kevin-brown
Copy link
Member

Should ultimately be fixed by #5558.

@kevin-brown kevin-brown closed this Jul 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants