Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test against jQuery 3.4.1 #5531

Merged
merged 3 commits into from Jun 26, 2019
Merged

Test against jQuery 3.4.1 #5531

merged 3 commits into from Jun 26, 2019

Commits on May 26, 2019

  1. Update tests to be compatible with jQuery 3.0.0 

    There was a change in jQuery 3 that ensures that the return value of `.val()` on a multiple select is always an array. This is a breaking change from previous versions, where `null` or `undefined` were returned in these scenarios. Because we cannot `assert.equal` on a list of possible values, these assertions were switched to `assert.ok` which should be good enough.
    @kevin-brown
    kevin-brown committed May 26, 2019
    Copy the full SHA
    2c48cce View commit details
    Browse the repository at this point in the history

  2. Properly strip out units in positioning tests 

    Before we were assuming that there were no units, and only were we stripping them out if we were expecting 3 digits. Now we just strip out all non-digit characters, so that should do the job and get us what we want.

There was a change in jQuery 3.2.0 that caused the units to be returned in these specific calls. They were not previously being returned, so this was not actually an issue.
    @kevin-brown
    kevin-brown committed May 26, 2019
    Copy the full SHA
    e3e1dad View commit details
    Browse the repository at this point in the history

  3. Add automated testing against jQuery 3.4.1 

    No tests appear to be currently failing.
    @kevin-brown
    kevin-brown committed May 26, 2019
    Copy the full SHA
    e6b87ed View commit details
    Browse the repository at this point in the history