Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent too many items. #5533

Closed
wants to merge 1 commit into from
Closed

Prevent too many items. #5533

wants to merge 1 commit into from

Conversation

JacobLuckhardt
Copy link

@JacobLuckhardt JacobLuckhardt commented Jun 5, 2019 •
edited

This pull request includes a

  • Bug fix
  • New feature
  • Translation

The following changes were made

  • When selecting a new item, the eventRelay will trigger the maximumSelected message if the maximumSelectionLength is reached. This will prevent the user from adding more than maximumSelectionLength items, in case he is holding ctrl or closeOnSelect is false.

This will fix these issues:
#3514
#3860

@JacobLuckhardt JacobLuckhardt mentioned this pull request Jun 5, 2019
Closed
@JacobLuckhardt
Prevent too many items.
0624d6d 
Display the corresponding message when maximumSelectionLength is reached.
This will prevent the user from adding too many items by holding the ctrl key or when closeOnSelect is false.
@kevin-brown
Copy link
Member

Fixed with tests in #5581.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@JacobLuckhardt @kevin-brown