Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert change to focusing behaviour in 4.0.6 #5576

Merged
merged 1 commit into from Jul 21, 2019
Merged

Revert change to focusing behaviour in 4.0.6 #5576

merged 1 commit into from Jul 21, 2019

Commits on Jul 21, 2019

  1. Revert change to focusing behaviour in 4.0.6

    This behaviour, where the focus was happening on a small asynchronous
    delay, was added in commit 933189b late last year in a commit with
    no supporting tickets or commit message explaining what the change
    was trying to accomplish. This commit has effectly been reverted within
    this commit, since it caused a regression in how focus was being
    assigned that made it inconsistent with a standard `<select>`.
    
    A test was added for this which ensures that we won't see that
    regression again.
    
    Fixes #5532
    Fixes #5185
    Closes #5552
    kevin-brown committed Jul 21, 2019
    Copy the full SHA
    67fb702 View commit details
    Browse the repository at this point in the history