Commits on Jul 21, 2019

1. Rewrote maximumSelectionLength tests to use container …

   These brings the tests in line with other tests which we have, and
   makes it easier to understand what is actually going on in the tests.
   
   This also removes a redundant set of tests where we were testing with
   => 2 options being allowed. There are no current edge cases that would
   have required this.

   

   kevin-brown committed Jul 21, 2019
   Copy the full SHA

   7da17ea View commit details

   Browse the repository at this point in the history

2. Fix maximumSelectionLength being ignored by closeOnSelect …

   There was a bug where the `maximumSelectionLength` option would not
   kick in if the `closeOnSelect` option was enabled. Normally, this
   was enabled by someone in their global configuration, but it could
   also be seen when somoene selected an option while holding the
   meta/ctrl/alt keys. This would implicitly enable the `closeOnSelect`
   behaviour, even when it was not globally enabled, and cause the bug.
   
   This fixes that issue by listening to the `select` event which is
   triggered whenever an option is selected, and triggers the "maximum
   selected" message based on that event. This should now force the
   message to be displayed, even when the results did not have to be
   queried another time.
   
   Fixes #3514
   Fixes #3860
   Closes #5333

   

   kevin-brown committed Jul 21, 2019
   Copy the full SHA

   7767663 View commit details

   Browse the repository at this point in the history