Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reposition dropdown whenever items are selected #5590

Merged
merged 2 commits into from Jul 28, 2019
Merged

Commits on Jul 26, 2019

  1. Reposition dropdown whenever items are selected

    This fixes an old bug where if you had a multiple select with the
    `closeOnSelect` option set to `false` and many options being
    selected, the dropdown would not reposition itself if the selected
    options expanded the container down another line. This was because
    the dropdown was only being repositioned when it was opened, closed,
    or if something around it was scrolled or resized. Unfortunately,
    in most cases none of these happened and the dropdown would start
    covering the selections.
    
    This was fixed by telling Select2 to resize the dropdown when new
    options are selected or existing options are unselected.
    
    Fixes #4377
    kevin-brown committed Jul 26, 2019
    Copy the full SHA
    0519a59 View commit details
    Browse the repository at this point in the history
  2. Attach positioning handlers at bind time

    The positioning handlers have been attached at the time that the
    dropdown is opened since when they were first committed many years
    ago. It's not actually clear why this was being done, since they
    don't rely on anything involving the dropdown being open. This
    removes the flag and process for setting these handlers only after
    the dropdown was opened for the first time, and moves these handlers
    to always be set at bind time.
    kevin-brown committed Jul 26, 2019
    Copy the full SHA
    3f75227 View commit details
    Browse the repository at this point in the history