Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dropdown positioning when displayed above with messages #5592

Merged
merged 1 commit into from Jul 28, 2019

Commits on Jul 28, 2019

  1. Fix dropdown positioning when displayed above with messages

    This fixes an issue which was usually observed when working with
    AJAX results sets and having a message being displayed, usually the
    minimum characters message or an error. The dropdown would display
    up, like it was supposed to, but the message would appear to be
    floating above the container and detached.
    
    This was occuring because the dropdown position was not being
    calculated whenever a message was displayed in the results, only
    when the results were loaded or new results were appended to an existing
    results set. There are plenty of situations where this could have
    caused issues, but somehow most of the reports were around a very
    specific situation with AJAX which could be reproduced on the
    examples site.
    
    Fixes #4614
    Fixes #4616
    Fixes #5253
    Closes #5196
    AStoker authored and kevin-brown committed Jul 28, 2019
    Copy the full SHA
    c33f8e0 View commit details
    Browse the repository at this point in the history