Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix NPM deployment #5686

Merged
merged 2 commits into from Oct 31, 2019
Merged

Fix NPM deployment #5686

merged 2 commits into from Oct 31, 2019

Commits on Oct 28, 2019

  1. Fix deploying to NPM 

    This changes the NPM registry URL to point to the actual NPM registry
instead of the GitHub package registry.
    @kevin-brown
    kevin-brown committed Oct 28, 2019
    Copy the full SHA
    796ab7b View commit details
    Browse the repository at this point in the history

  2. Delay documentation deployment 

    This should hopefully fix any possible issues where the NPM package
may be released after the documentation is deployed, which could cause
a cause miss by jsDelivr and cause the documentation to cache without
pulling in the Select2 dependency.

It hasn't happened yet, but I'm concerned it could happen and I don't
want to put in the effort to make a more sophisticated way of
handling this issue.
    @kevin-brown
    kevin-brown committed Oct 28, 2019
    Copy the full SHA
    37773d4 View commit details
    Browse the repository at this point in the history