Prevent fields from toggling open when cleared #6032
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no reason to assume the user wants to open the field when they hit the clear button. If the field is open when the clear button is selected it will be closed as normal.
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when the
_handleClearevent fires the field will be closed if it was opened (👍) and opened if it was previously closed (👎). I can think of no reason why anyone would want both of those to be the case, and in most cases I expect it would be undesirable to have fields automatically opening when they’re cleared.Anyone that wants to select a different option can already click in any other part of the field to open it up and select a new value – someone that clicks the clear button is explicitly choosing not to do that.
This is discussed in #3320 and clearly a lot of people feel the same way. I appreciate the request was denied before, but I thought I’d submit a very clean/simple PR before resorting to a nasty local hack in my project.
This pull request includes a
The following changes were made