Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(renovate-branches): define decision to not build renovate branches in test workflows #5

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

docs(renovate-branches): define decision to not build renovate branches in test workflows #5

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
356ed66
docs(renovate-branches): define decision to not build renovate branch…
travi Nov 17, 2020
c713814
docs: fix typo and add punctuation
travi Nov 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
28 changes: 28 additions & 0 deletions architecture-decisions/0002-avoid-building-renovate-branches.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
# 2. Avoid building renovate branches

Date: 2020-11-16

## Status

Accepted

## Context

In order for renovate PR branches to be built in isolation, they could be
included in the list under the `push` trigger in the test workflow as
`renovate/**`. However, that would result in duplication for the builds
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we might soon revert the decision as it looks like we will enable automergeType:branch as discussed at #3

If now pull requests are created, we will have to enable builds on push for the renovate branches

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep, understood. just thought it would be a decent example of making a decision and later making a super-ceding decision. mostly just going through the motions, so i'm cool if we want to skip this one as wasteful

triggered by the PR being opened or updated.

These two build types are intended to catch differing problems between the
isolated branch vs the branch merged with the mainline. However, as short-lived
as the renovate PRs are intended to be, it should be rare that the results of
the two builds are different.

## Decision

We will not build the renovate branches as part of the test workflows.

## Consequences

Redundant builds will be avoided and we will rely on the PR builds to verify
that the dependency updates are safe to merge.