Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: updated error to rightly signify what happened and work around #185

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix: updated error to rightly signify what happened and work around #185

wants to merge 3 commits into from
+6 −5

Conversation

theoomoregbee
Copy link

No description provided.

kbrandwijk
kbrandwijk suggested changes Jan 29, 2018
View reviewed changes
Copy link
Member

@kbrandwijk kbrandwijk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's actually not an accurate error description. Token being null at that stage might be caused by anything relating to authentication. Wrong username or password for example.

@theoomoregbee
Copy link
Author

oh ok, will do a workaround to make it show the cause of the error at a particular state

@theoomoregbee theoomoregbee changed the title fix: updated error to rightly signify what happened and work around [WIP] fix: updated error to rightly signify what happened and work around Mar 14, 2018
@theoomoregbee theoomoregbee changed the title [WIP] fix: updated error to rightly signify what happened and work around fix: updated error to rightly signify what happened and work around Mar 17, 2018
@theoomoregbee
Copy link
Author

@kbrandwijk you can have a look again

@theoomoregbee theoomoregbee mentioned this pull request Mar 30, 2018
Closed
@theoomoregbee
Copy link
Author

@gr2m you can have a look at this PR

@gr2m
Copy link
Member

gr2m commented Mar 30, 2018

I’m out for vacation for 3 weeks, sorry ✌️

@pvdlg pvdlg added the cli label May 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kbrandwijk kbrandwijk kbrandwijk requested changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
cli
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@theoomoregbee @gr2m @kbrandwijk @pvdlg